wchevreuil commented on code in PR #5339:
URL: https://github.com/apache/hbase/pull/5339#discussion_r1281706889
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##########
@@ -53,7 +56,8 @@ public final class PrefetchExecutor {
private static final Map<Path, Future<?>> prefetchFutures = new
ConcurrentSkipListMap<>();
/** Set of files for which prefetch is completed */
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value =
"MS_SHOULD_BE_FINAL")
- private static HashMap<String, Boolean> prefetchCompleted = new HashMap<>();
+ private static ConcurrentHashMap<String, Long> regionPrefetchSizeMap = new
ConcurrentHashMap<>();
+ private static HashMap<String, Map<String, Long>> prefetchCompleted = new
HashMap<>();
Review Comment:
How about using Pair<String,Long> as the map value? We don't really need a
map as the value here. You can use `org.apache.hadoop.hbase.util.Pair` here, I
believe it would be clearer to understand the structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
