[ 
https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412069#comment-13412069
 ] 

stack commented on HBASE-6336:
------------------------------

+1 on the patch.

@Ram when you say 'But here in the first region there are no kvs at all and 
hence we flush an empty file.'

What flush are you talking of?  The close of the region on split?  If so, why 
we write a flush file if no KVs?  Do we?  That don't seem right.

                
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
>                 Key: HBASE-6336
>                 URL: https://issues.apache.org/jira/browse/HBASE-6336
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
>         // (ever) split this region.
>         if (this.comparator.compareRows(mk, firstKey) == 0 &&
>             this.comparator.compareRows(mk, lastKey) == 0) {
>           if (LOG.isDebugEnabled()) {
>             LOG.debug("cannot split because midkey is the same as first or " +
>               "last row");
>           }
> {code}
> Here, I think it is a mistake.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to