ryakhovskiy commented on PR #5343:
URL: https://github.com/apache/hbase/pull/5343#issuecomment-1668120488

   does not make sense to check the NPE in the Test.
   Needs to have more graceful way to deal with misconfiguration, like 
non-positive values of "hbase.lru.blockcache.hard.capacity.limit.factor", e.g. 
log a warning and return empty block instead of null.
   
   this will require a bit of refactoring


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to