Reidddddd commented on code in PR #120:
URL: https://github.com/apache/hbase-connectors/pull/120#discussion_r1286553972
##########
kafka/hbase-kafka-proxy/src/main/java/org/apache/hadoop/hbase/kafka/KafkaTableForBridge.java:
##########
@@ -75,106 +73,94 @@ public RegionLocator getRegionLocator() throws IOException
{
throw new UnsupportedOperationException();
}
- public KafkaTableForBridge(TableName tableName,
- Configuration conf,
- TopicRoutingRules routingRules,
- Producer<byte[],byte[]> producer,
- DatumWriter<HBaseKafkaEvent> avroWriter){
- this.conf=conf;
- this.tableName=tableName;
- this.tableAsBytes=this.tableName.toBytes();
- this.routingRules=routingRules;
- this.producer=producer;
- this.avroWriter=avroWriter;
+ public KafkaTableForBridge(TableName tableName, Configuration conf,
+ TopicRoutingRules routingRules, Producer<byte[], byte[]> producer,
+ DatumWriter<HBaseKafkaEvent> avroWriter) {
Review Comment:
One style nit, could we config style like these:
```
public KafkaTableForBridge(TableName tableName, Configuration conf,
TopicRoutingRules routingRules, Producer<byte[], byte[]> producer,
DatumWriter<HBaseKafkaEvent> avroWriter) {
this.conf = conf;
```
add one more indent for a newline after a method declaration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
