wchevreuil commented on code in PR #5341:
URL: https://github.com/apache/hbase/pull/5341#discussion_r1290636965
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -589,6 +588,12 @@ public Cacheable getBlock(BlockCacheKey key, boolean
caching, boolean repeat,
}
return cachedBlock;
}
+ } catch (HBaseIOException hioex) {
+ // When using file io engine persistent cache,
+ // the cache map state might differ from the actual cache. If we reach
this block,
+ // we should remove the cache key entry from the backing map
+ backingMap.remove(key);
+ LOG.debug("Failed to fetch block for cache key: {}.", key, hioex);
Review Comment:
It's in FileIOEngine, when we read the block we do the cached time
verification and if it fails we throw it
[here](https://github.com/apache/hbase/pull/5341/files#diff-6fd439db6391991c41246fd4d85d39853f14443c1202ca5c84428836e646d699R156).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
