ericsun95 commented on code in PR #40:
URL: https://github.com/apache/hbase-connectors/pull/40#discussion_r1292791382
##########
spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/HBaseContext.scala:
##########
@@ -463,6 +466,81 @@ class HBaseContext(@transient val sc: SparkContext,
(r: (ImmutableBytesWritable, Result)) => r)
}
+ /**
+ *
+ * @param snapshotName the name of the snapshot to scan
+ * @param scans the HBase scan object to use to read data
from HBase
+ * @param restoreDir a temporary directory to restore the snapshot
into. Current user should
+ * have write permissions to this directory,
+ * and this should not be a subdirectory of
rootdir.
+ * After the job is finished, restoreDir can be
deleted.
+ * @return New RDD with results from scan
+ */
Review Comment:
This is a very nice feature. Do we have any tests though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
