ragarkar commented on code in PR #5341:
URL: https://github.com/apache/hbase/pull/5341#discussion_r1292975634
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java:
##########
@@ -77,6 +78,11 @@ public void run() {
block.release();
}
}
+ cacheConf.getBlockCache().ifPresent(bc -> {
+ if (bc instanceof BucketCache) {
+ ((BucketCache) bc).fileCacheCompleted(path.getName());
+ }
Review Comment:
IIUC, persistent cache is only for L2 cache. I think, we need to get the
instance of L2 cache only if the blockcache is an instance of
CombinedBlockCache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
