jbewing commented on code in PR #5347:
URL: https://github.com/apache/hbase/pull/5347#discussion_r1293984871
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java:
##########
@@ -954,25 +1033,55 @@ private int compareTypeBytes(Cell key, Cell right) {
return 0;
}
+ // These findCommonPrefix* methods rely on the fact that keyOnlyKv is the
"right" cell argument
Review Comment:
Good call! In
https://github.com/apache/hbase/pull/5347/commits/458e99f78c6b6cce383b92abec9568fff496ffae,
I've changed the type of the right cell to be `KeyValue.KeyOnlyKeyValue` s.t.
if the upper layer is refactored the author will be forced to address the
resulting type errors. Let me know if you had something more comprehensive in
mind here @Apache9 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
