[
https://issues.apache.org/jira/browse/HBASE-28028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755561#comment-17755561
]
Andrew Kyle Purtell commented on HBASE-28028:
---------------------------------------------
readFully() is exactly what I had in the initial implementation. This buffering
is an “extra” copy. A colleague working with me at the time convinced me to try
relying on the stream implementations of the codecs to avoid the extra copy.
However it seems that is not always reliable.
+1 for putting readFully back in the decompression code path. It provides
reliability, which is the most important thing. For performance, if it is
really a measured problem here for someone in the future, we can come back to
this.
> Read all compressed bytes to a byte array before submitting them to
> decompressor
> --------------------------------------------------------------------------------
>
> Key: HBASE-28028
> URL: https://issues.apache.org/jira/browse/HBASE-28028
> Project: HBase
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
