Apache9 commented on code in PR #5361:
URL: https://github.com/apache/hbase/pull/5361#discussion_r1301186292
##########
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon:
##########
@@ -701,17 +703,43 @@ AssignmentManager assignmentManager =
master.getAssignmentManager();
<th></th>
<th>ServerName</th>
<th>Stop time</th>
+ <%if !master.isInMaintenanceMode() &&
master.getMasterCoprocessorHost() != null
+ &&
master.getMasterCoprocessorHost().findCoprocessor("RSGroupAdminEndpoint") !=
null
+ && master.getServerManager().getOnlineServersList().size() > 0 %>
+ <th>RSGroup</th>
+ </%if>
</tr>
<%java>
- DeadServer deadServerUtil = master.getServerManager().getDeadServers();
- ServerName [] deadServerNames = deadServers.toArray(new
ServerName[deadServers.size()]);
- Arrays.sort(deadServerNames);
- for (ServerName deadServerName: deadServerNames) {
+ List<RSGroupInfo> groups = null;
+ DeadServer deadServerUtil = master.getServerManager().getDeadServers();
+ if (!master.isInMaintenanceMode() && master.getMasterCoprocessorHost()
!= null
+ &&
master.getMasterCoprocessorHost().findCoprocessor("RSGroupAdminEndpoint") !=
null
+ && master.getServerManager().getOnlineServersList().size() > 0) {
+ groups =
RSGroupTableAccessor.getAllRSGroupInfo(master.getConnection());
+ }
+ ServerName [] deadServerNames = deadServers.toArray(new
ServerName[deadServers.size()]);
+ Arrays.sort(deadServerNames);
+ for (ServerName deadServerName: deadServerNames) {
+ String rsGroupName = null;
Review Comment:
The indentation is a bit strange? We use 2 spaces instead of 4 spaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
