NihalJain commented on PR #135:
URL: 
https://github.com/apache/hbase-operator-tools/pull/135#issuecomment-1690281118

   Based on code, I was able to identify 3 commands: `assigns`, `unassigns` and 
`bypass`, which should have batching in case large list of input is passed and 
have made a change for same. 
   
   Please let me know, in case I missed any other command, for which we could 
add batching.
   
   Also I find the semantics of what is print in sysout is not well defined. 
For few commands, say `assigns`, it prints output as a list as follows: `[425, 
426, 427, 428, 429]`; while for others, like `unassigns`, `bypass` it prints as 
follows: `415, 416, 417, 418, 419`
   
   I feel we should keep this in sync across commands, by following either 
approach (I prefer `[425, 426, 427, 428, 429]`), to ease parsing of the 
outputs. Let me know what do you think about this; I can raise a JIRA to fix 
the same.
   
   CC: @wchevreuil , @petersomogyi


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to