[ 
https://issues.apache.org/jira/browse/HBASE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412686#comment-13412686
 ] 

Harsh J commented on HBASE-5151:
--------------------------------

bq. This is another reason we need versioning in patch filenames so that such 
mistakes can be more easily avoided.

Understood Ted. When posting patches over HBASE in future, I'll make sure to 
number them every revision. Thanks! :)
                
> Rename "hbase.skip.errors" in HRegion as it is too general-sounding.
> --------------------------------------------------------------------
>
>                 Key: HBASE-5151
>                 URL: https://issues.apache.org/jira/browse/HBASE-5151
>             Project: HBase
>          Issue Type: Sub-task
>          Components: documentation
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5151.amend.patch, HBASE-5151.amend.wrapped.patch, 
> HBASE-5151.patch, HBASE-5151.patch, HBASE-5151.patch
>
>
> We should rename "hbase.skip.errors", used in HRegion.java for skipping 
> errors when replaying edits. It should probably be something more like 
> "hbase.hregion.edits.replay.skip.errors" or so.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to