[ 
https://issues.apache.org/jira/browse/HBASE-27919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760967#comment-17760967
 ] 

Duo Zhang commented on HBASE-27919:
-----------------------------------

Confirm. This is a problem.

{code}
  public void takeSnapshot(SnapshotDescription snapshot) throws IOException {
    this.takingSnapshotLock.readLock().lock();
    try {
      takeSnapshotInternal(snapshot);
    } finally {
      this.takingSnapshotLock.readLock().unlock();
    }
  }

  public synchronized long takeSnapshot(SnapshotDescription snapshot, long 
nonceGroup, long nonce)
    throws IOException {
    this.takingSnapshotLock.readLock().lock();
    try {
      return submitSnapshotProcedure(snapshot, nonceGroup, nonce);
    } finally {
      this.takingSnapshotLock.readLock().unlock();
    }
  }
{code}

It is a bit strange that why one method is synchronized while another is not.

Let me dig more.

Thanks [~luoen].

> Run ITBLL for branch-3
> ----------------------
>
>                 Key: HBASE-27919
>                 URL: https://issues.apache.org/jira/browse/HBASE-27919
>             Project: HBase
>          Issue Type: Sub-task
>          Components: integration tests
>            Reporter: Duo Zhang
>            Assignee: Haiping lv
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to