apurtell commented on code in PR #5391:
URL: https://github.com/apache/hbase/pull/5391#discussion_r1323672892
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java:
##########
@@ -306,6 +308,10 @@ private boolean scheduleForRetry(IOException e) {
serverName, e.toString(), numberOfAttemptsSoFar);
return false;
}
+ if (isSaslError(e) && numberOfAttemptsSoFar == 0) {
Review Comment:
Does it matter how many attempts we have had so far if now we are getting a
SASL error?
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##########
@@ -347,7 +348,7 @@ public void operationComplete(ChannelFuture future) throws
Exception {
private void sendRequest0(Call call, HBaseRpcController hrc) throws
IOException {
assert eventLoop.inEventLoop();
if (reloginInProgress) {
- throw new IOException("Can not send request because relogin is in
progress.");
+ throw new IOException(HConstants.RELOGIN_IS_IN_PROGRESS);
Review Comment:
This is weird, please don't put these kinds of constants in HConstants.
There are too many unrelated concerns there already.
Public static string constant in some other file, even this one, is
preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
