[
https://issues.apache.org/jira/browse/HBASE-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413272#comment-13413272
]
Hadoop QA commented on HBASE-6334:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12536278/HBASE-6334-trunk-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2371//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2371//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2371//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2371//console
This message is automatically generated.
> TestImprovement for TestHRegion.testWritesWhileGetting
> ------------------------------------------------------
>
> Key: HBASE-6334
> URL: https://issues.apache.org/jira/browse/HBASE-6334
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.92.2, 0.94.1
>
> Attachments: HBASE-6334-92-v2.patch, HBASE-6334-94-v2.patch,
> HBASE-6334-trunk-v2.patch, HBASE-6334-trunk.patch
>
>
> Two improvements:
> 1. I was running testWritesWhileGetting on 0.90.6 (which lacks HBASE-4195)
> and I couldn't get the 20% failures mentioned in the JIRA. It was more like
> 1%. So I increased the flush frequency and it failed most of the time.
> 2. The check on failure is wrong:
> {code}
> assertEquals(previousKV.getValue(), thisValue);
> {code}
> Since this is a byte array, we should use Bytes.compareTo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
