bbeaudreault commented on code in PR #5402:
URL: https://github.com/apache/hbase/pull/5402#discussion_r1330451481
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java:
##########
@@ -72,11 +73,12 @@ class ScannerCallableWithReplicas implements
RetryingCallable<Result[]> {
public ScannerCallableWithReplicas(TableName tableName, ClusterConnection
cConnection,
ScannerCallable baseCallable, ExecutorService pool, int
timeBeforeReplicas, Scan scan,
- int retries, int readRpcTimeout, int scannerTimeout, int caching,
Configuration conf,
- RpcRetryingCaller<Result[]> caller) {
+ int retries, int readRpcTimeout, int scannerTimeout, boolean
useScannerTimeoutForNextCalls,
Review Comment:
Actually, it's not so simple here. The readRpcTimeout and scannerTimeout
both can be overridden on a per-Table basis via TableBuilder. Caching can be
overridden by the Scan. So really just retries and my new boolean could be
unified in this way. I could do it, but yea trying not to refactor too much.
Also I could imagine making retries configurable via TableBuilder in the future
which would negate this change... not necessarily somethign we should design
for, just saying.
Yes, this code goes away in 3.0, but I'm sure we'll be maintaining it for
years to come. So I think it's worth doing useful refactors, but not sure this
one qualifies given the special cases above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
