Apache9 commented on code in PR #5389:
URL: https://github.com/apache/hbase/pull/5389#discussion_r1334930311
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -273,6 +273,7 @@ public BucketCache(String ioEngineName, long capacity, int
blockSize, int[] buck
public BucketCache(String ioEngineName, long capacity, int blockSize, int[]
bucketSizes,
int writerThreadNum, int writerQLen, String persistencePath, int
ioErrorsTolerationDuration,
Configuration conf) throws IOException {
+ Preconditions.checkArgument(blockSize > 0, "BucketCache capacity can not
be less than 0");
Review Comment:
Better to include the incorrect blockSize value in the error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
