NihalJain commented on code in PR #5431:
URL: https://github.com/apache/hbase/pull/5431#discussion_r1335044688
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.java:
##########
@@ -126,6 +126,36 @@ public void write(ChannelHandlerContext ctx, Object msg,
ChannelPromise promise)
}
}
+ private void finishCall(ResponseHeader responseHeader, ByteBufInputStream
in, Call call)
+ throws IOException {
+ Message value;
+ if (call.responseDefaultType != null) {
+ Message.Builder builder = call.responseDefaultType.newBuilderForType();
+ if (!builder.mergeDelimitedFrom(in)) {
+ // The javadoc of mergeDelimitedFrom says returning false means the
stream reaches EOF
+ // before reading any bytes out, so here we need to manually throw the
EOFException out
Review Comment:
nit: now since we are not immediately throwing `EOFException`, maybe we
should update this comment here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
