bbeaudreault commented on code in PR #5447:
URL: https://github.com/apache/hbase/pull/5447#discussion_r1346097879
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java:
##########
@@ -548,6 +549,19 @@ protected void processRequest(ByteBuff buf) throws
IOException, InterruptedExcep
Span span = TraceUtil.createRemoteSpan("RpcServer.process", traceCtx);
try (Scope ignored = span.makeCurrent()) {
int id = header.getCallId();
+ // HBASE-28128 - if server is aborting, don't bother trying to process.
It will
+ // fail at the handler layer, but worse might result in
CallQueueTooBigException if the
+ // queue is full but server is not properly processing requests. Better
to throw an aborted
+ // exception here so that the client can properly react.
+ if (rpcServer.server != null && rpcServer.server.isAborted()) {
Review Comment:
This comes from tests actually, a few pass in null and were causing NPEs. I
figured it was safest to null check it rather than mock all of those cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
