frostruan commented on code in PR #5408:
URL: https://github.com/apache/hbase/pull/5408#discussion_r1349529689
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java:
##########
@@ -762,4 +773,30 @@ public static String findMostRecentBackupId(String[]
backupIds) {
return BackupRestoreConstants.BACKUPID_PREFIX + recentTimestamp;
}
+ public static void rollWALWriters(Admin admin, Map<String, String> props)
throws IOException {
+ byte[] ret =
Review Comment:
a. it is not general enough for `Admin`. This call will not only make all rs
roll WAL writers, but also do some backup-related operations, such as reading
and writing BackupSystemTable.
b. this operation is a bit too lightweight if introduced in the
`BackupAdmin`, since it's only a small subprocedure of the whole backup job.
So I think maybe a static utility method is enough ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
