wchevreuil commented on PR #5470: URL: https://github.com/apache/hbase/pull/5470#issuecomment-1771695919
> > An extra thought I have is if we should implement this as a separate "isolate_regions" operation, rather than being an option to "unload". It sounds more intuitive to me, wdyt? > > @wchevreuil That a good suggestion. Let me look into it. Earlier I planned this feature as separate class from `RegionMover` but it lead to lot of code duplication. I will try your suggestion today. > > Thanks for the review. @wchevreuil Oh, I thought about implement this `isolate` in the RegionMover itself, just as a third operation. This way, I think you could reuse the whole original `unload` (or most of it) inside your `isolate` method. Then RegionMover would now have three operations: load/unload/isolate. In hbck2 we do a lot of "composable" operations, some granular and others aggregated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
