bbeaudreault commented on code in PR #2038:
URL: https://github.com/apache/hbase/pull/2038#discussion_r1373743878
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java:
##########
@@ -103,38 +104,38 @@ private void checkObsoleteConfigurations() {
@VisibleForTesting
public MobFileCleanerChore() {
+ // maybe remove? We can do little if the master is null, even in unit test.
this.master = null;
}
@Override
protected void chore() {
TableDescriptors htds = master.getTableDescriptors();
-
- Map<String, TableDescriptor> map = null;
+ Collection<TableDescriptor> mobTableDescriptors;
try {
- map = htds.getAll();
+ mobTableDescriptors = htds.getAll().values();
} catch (IOException e) {
LOG.error("MobFileCleanerChore failed", e);
return;
}
- for (TableDescriptor htd : map.values()) {
- for (ColumnFamilyDescriptor hcd : htd.getColumnFamilies()) {
- if (hcd.isMobEnabled() && hcd.getMinVersions() == 0) {
+ for (TableDescriptor t : mobTableDescriptors) {
Review Comment:
lets remove these unnecessary rename diffs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
