wchevreuil commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1376086992
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##########
@@ -104,6 +115,55 @@ protected void preflightChecks(MasterProcedureEnv env,
Boolean enabled) throws H
}
}
}
+ if (!reopenRegions) {
+ if (this.unmodifiedTableDescriptor == null) {
+ throw new HBaseIOException(
+ "unmodifiedTableDescriptor cannot be null when this table
modification won't reopen regions");
+ }
+ if (
+ 0 != this.unmodifiedTableDescriptor.getTableName()
+ .compareTo(this.modifiedTableDescriptor.getTableName())
Review Comment:
nit: use `equals`
##########
hbase-shell/src/main/ruby/shell/commands/alter.rb:
##########
@@ -72,6 +72,13 @@ def help
hbase> alter 't1', CONFIGURATION =>
{'hbase.hregion.scan.loadColumnFamiliesOnDemand' => 'true'}
hbase> alter 't1', {NAME => 'f2', CONFIGURATION =>
{'hbase.hstore.blockingStoreFiles' => '10'}}
+You can also set configuration setting with REOPEN_REGIONS=>'false' to avoid
regions RIT, which
Review Comment:
Can we also explain the type of changes that don't allow `reopen=false`,
such as adding/removing CFs or changing table name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
