[ 
https://issues.apache.org/jira/browse/HBASE-28185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782090#comment-17782090
 ] 

chaijunjie commented on HBASE-28185:
------------------------------------

after this patch, i test again
{code:java}
hbase:001:0> alter 'test',{NAME=>'f1',TTL=>'111x'}
2023-11-02 18:09:43,377 WARN  [main] util.PrettyPrinter: Given interval value : 
111x is not a number and not match human readable format, ttl will set to 
0.ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: TTL for column family 
f1 must be positive. Set hbase.table.sanity.checks to false at conf or table 
descriptor if you want to bypass sanity checks
    at 
org.apache.hadoop.hbase.util.TableDescriptorChecker.warnOrThrowExceptionForFailure(TableDescriptorChecker.java:321)
    at 
org.apache.hadoop.hbase.util.TableDescriptorChecker.sanityCheck(TableDescriptorChecker.java:165)
    at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2666)
    at 
org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:132)
    at org.apache.hadoop.hbase.master.HMaster.modifyTable(HMaster.java:2660)
    at org.apache.hadoop.hbase.master.HMaster.modifyTable(HMaster.java:2698)
    at 
org.apache.hadoop.hbase.master.MasterRpcServices.modifyTable(MasterRpcServices.java:1554)
    at 
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
    at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:477)
    at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123)
    at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:369)
    at 
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:349)For 
usage try 'help "alter"'
 {code}
will raise a PR by this

> Alter table to set TTL using hbase shell failed when ttl string is not match 
> format
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-28185
>                 URL: https://issues.apache.org/jira/browse/HBASE-28185
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.4.14
>            Reporter: chaijunjie
>            Assignee: chaijunjie
>            Priority: Minor
>         Attachments: HBASE-28185.patch
>
>
> create 'test','f1'
> alter 'test',\{NAME=>'f1',TTL=>'111x'}
>  
> {code:java}
> hbase:001:0> alter 'test',{NAME=>'f1',TTL=>'111x'}
> ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: TTL for column family 
> f1 must be positive. Set hbase.table.sanity.checks to false at conf or table 
> descriptor if you want to bypass sanity checks       at 
> org.apache.hadoop.hbase.util.TableDescriptorChecker.warnOrThrowExceptionForFailure(TableDescriptorChecker.java:321)
>   at 
> org.apache.hadoop.hbase.util.TableDescriptorChecker.sanityCheck(TableDescriptorChecker.java:165)
>      at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2666)     
> at 
> org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:132)
>    at org.apache.hadoop.hbase.master.HMaster.modifyTable(HMaster.java:2660)   
>      at org.apache.hadoop.hbase.master.HMaster.modifyTable(HMaster.java:2698) 
>        at 
> org.apache.hadoop.hbase.master.MasterRpcServices.modifyTable(MasterRpcServices.java:1554)
>     at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>  at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:477)       at 
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123)      at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:369)    
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:349)
> For usage try 'help "alter"' {code}
> it is misleading..
>  
> we need tell user wether theire command is wrong..
> some times we copy some string which may have some invisible characters, we 
> need let user to check it



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to