[ 
https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415679#comment-13415679
 ] 

Jonathan Hsieh commented on HBASE-4072:
---------------------------------------

Code looks good.  Adding a test for this should be straightforwards -- have two 
different HBaseConfigurations (one with the new setting true and one with the 
new setting false), the check the properties.  If the zoo.cfg file is not 
present and there are no zk settings we end up returning defaults.
                
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from 
> the classpath
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4072
>                 URL: https://issues.apache.org/jira/browse/HBASE-4072
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.0
>            Reporter: stack
>            Assignee: Harsh J
>         Attachments: HBASE-4072.patch
>
>
> This issue was found by Lars: 
> http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk 
> attribute name for a zk attribute in hbase (There's only a few places that I 
> remember -- maximum client connections is one IIRC)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to