virajjasani commented on code in PR #5503:
URL: https://github.com/apache/hbase/pull/5503#discussion_r1382734340
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java:
##########
@@ -470,7 +470,27 @@ private Pair<WALTailingReader.State, Boolean>
readNextEntryAndRecordReaderPositi
// in the future, if we want to optimize the logic here, for example, do
not call this method
// every time, or do not acquire rollWriteLock in the implementation of
this method, we need to
// carefully review the optimized implementation
Review Comment:
nit: now that we have comments for both if and else, maybe good to remove
from here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
