Apache9 commented on code in PR #5444:
URL: https://github.com/apache/hbase/pull/5444#discussion_r1386720257
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java:
##########
@@ -219,10 +219,16 @@ static String[] getDefaultCipherSuites(boolean
useOpenSsl) {
static String[] getDefaultCipherSuitesForJavaVersion(String javaVersion) {
Objects.requireNonNull(javaVersion);
+
if (javaVersion.matches("\\d+")) {
// Must be Java 9 or later
- LOG.debug("Using Java9+ optimized cipher suites for Java version {}",
javaVersion);
- return DEFAULT_CIPHERS_JAVA9;
+ int javaVersionInt = Integer.parseInt(javaVersion);
+ if (javaVersionInt >= 11) {
+ return DEFAULT_CIPHERS_JAVA11;
Review Comment:
Add a log like "Using Java11+ xxx"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
