d-c-manning commented on code in PR #5522:
URL: https://github.com/apache/hbase/pull/5522#discussion_r1393616298
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java:
##########
@@ -510,38 +510,38 @@ public Void call() {
private Void readColumnFamily(Table table, ColumnFamilyDescriptor column) {
byte[] startKey = null;
- Get get = null;
- Scan scan = null;
+ Scan scan = new Scan();
ResultScanner rs = null;
StopWatch stopWatch = new StopWatch();
startKey = region.getStartKey();
// Can't do a get on empty start row so do a Scan of first element if
any instead.
if (startKey.length > 0) {
Review Comment:
is there any benefit to retaining the `Get` path? I legitimately don't know.
If there is, it seems like it could be possible to make a change where we
use `Get` only `if (startKey.length > 0 && !rawScanEnabled)`
But if `Get` is unnecessary, then your proposal is good, because it reduces
the complexity anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
