[
https://issues.apache.org/jira/browse/HBASE-28218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789554#comment-17789554
]
Hudson commented on HBASE-28218:
--------------------------------
Results for branch branch-3
[build #91 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/91/]:
(/) *{color:green}+1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/91/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/91/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/91/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add a check for getQueueStorage().hasData() in the getDeletableFiles method
> of ReplicationLogCleaner
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-28218
> URL: https://issues.apache.org/jira/browse/HBASE-28218
> Project: HBase
> Issue Type: Bug
> Components: wal
> Affects Versions: 3.0.0
> Reporter: Haiping lv
> Assignee: Haiping lv
> Priority: Major
> Fix For: 3.0.0-beta-1
>
>
> There are a large number of oldwal files in the oldwal directory, and the
> default value of hbase.master.logcleaner.ttl is 10 minutes. Upon observation,
> it has been noticed that no oldwal files have been cleared.
> Through analyzing the source code, it has been discovered that the following
> logic contains a problem. When LogCleaner executes the checkAndDeleteFiles
> method, it calls the getDeletableFiles method of ReplicationLogCleaner. One
> of the logics in this method is that if canFilter is false, it will directly
> return Collections.emptyList(), which means that the wal data filtered out by
> TimeToLiveLogCleaner will be filtered out. This in turn leads to the files
> under oldwal not being able to be cleared.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
