Apache9 commented on code in PR #5538:
URL: https://github.com/apache/hbase/pull/5538#discussion_r1405529967
##########
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java:
##########
@@ -1577,15 +1677,6 @@ private LockState
executeRollback(Procedure<TEnvironment> proc) {
LOG.error(HBaseMarkers.FATAL, "CODE-BUG: Uncaught runtime exception for
" + proc, e);
}
- // allows to kill the executor before something is stored to the wal.
- // useful to test the procedure recovery.
- if (testing != null && testing.shouldKillBeforeStoreUpdate()) {
Review Comment:
Yes. I split the condition for normal execution and rollback, so in some
tests we need to set both, for example, in TestProcedureRecovery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
