[
https://issues.apache.org/jira/browse/HBASE-28217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790902#comment-17790902
]
Hudson commented on HBASE-28217:
--------------------------------
Results for branch branch-2.4
[build #658 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/658/]:
(/) *{color:green}+1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/658/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/658/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/658/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/658/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> PrefetchExecutor should not run for files from CFs that have disabled
> BLOCKCACHE
> --------------------------------------------------------------------------------
>
> Key: HBASE-28217
> URL: https://issues.apache.org/jira/browse/HBASE-28217
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.6, 4.0.0-alpha-1
> Reporter: Wellington Chevreuil
> Assignee: Wellington Chevreuil
> Priority: Major
> Fix For: 2.6.0, 2.4.18, 3.0.0-beta-1, 4.0.0-alpha-1, 2.5.7
>
>
> HFilePReadReader relies on the return of CacheConfig.shouldPrefetchOnOpen
> return to decide if it should run the PrefetchExecutor for the files.
> Currently, CacheConfig.shouldPrefetchOnOpen returns true if
> "hbase.rs.prefetchblocksonopen" is set to true at the config, OR
> PREFETCH_BLOCKS_ON_OPEN is set to true at CF level.
> There's also the CacheConfig.shouldCacheDataOnRead, which returns true if
> both hbase.block.data.cacheonread is set to true at the config AND BLOCKCACHE
> is set to true at CF level.
> If BLOCKCACHE is set to false at CF level, HFilePReadReader will still run
> the PrefetchExecutor to read all the file's blocks from the FileSystem, but
> then would find out the given block shouldn't be cached.
> I believe we should change CacheConfig.shouldPrefetchOnOpen to return true
> only if CacheConfig.shouldCacheDataOnRead is also true.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
