Apache9 commented on code in PR #5548:
URL: https://github.com/apache/hbase/pull/5548#discussion_r1409298483
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/FlushRegionProcedure.java:
##########
@@ -28,16 +28,9 @@
import org.apache.hadoop.hbase.master.assignment.RegionStateNode;
import org.apache.hadoop.hbase.master.assignment.RegionStates;
import org.apache.hadoop.hbase.master.assignment.ServerState;
-import org.apache.hadoop.hbase.procedure2.FailedRemoteDispatchException;
-import org.apache.hadoop.hbase.procedure2.Procedure;
-import org.apache.hadoop.hbase.procedure2.ProcedureEvent;
-import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer;
-import org.apache.hadoop.hbase.procedure2.ProcedureSuspendedException;
-import org.apache.hadoop.hbase.procedure2.ProcedureUtil;
-import org.apache.hadoop.hbase.procedure2.ProcedureYieldException;
+import org.apache.hadoop.hbase.procedure2.*;
Review Comment:
Please avoid star imports?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/FlushRegionProcedure.java:
##########
@@ -88,6 +81,12 @@ protected Procedure<MasterProcedureEnv>[]
execute(MasterProcedureEnv env)
RegionStates regionStates = env.getAssignmentManager().getRegionStates();
RegionStateNode regionNode = regionStates.getRegionStateNode(region);
+ if (regionNode == null) {
+ LOG.warn(
Review Comment:
Since this is possible in normal flow, I think a debug log is enough? And
better add a comment to reference HBASE-28226 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
