[
https://issues.apache.org/jira/browse/HBASE-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416893#comment-13416893
]
Lars Hofhansl commented on HBASE-6418:
--------------------------------------
Are you sure Laxman?
This logic only needs to be done for version delete markers (not column or
family markers).
kv.isDeleteType() is only true to version delete markers.
KeyValue.isDelete(type) would be true for all delete markers.
I think it is correct the way it is.
> Minor bug in delete flow.
> -------------------------
>
> Key: HBASE-6418
> URL: https://issues.apache.org/jira/browse/HBASE-6418
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.96.0, 0.94.1, 0.94.2
> Reporter: Laxman
> Assignee: Laxman
>
> Timestamp updation in Delete flow is not considering all flavors (Delete
> record, Delete Family, Delete Column) of Delete API. Currently its
> considering Delete Record only.
>
> org.apache.hadoop.hbase.regionserver.HRegion.prepareDeleteTimestamps(Delete,
> byte[])
> {code}
> for (KeyValue kv: kvs) {
> // Check if time is LATEST, change to time of most recent addition
> if so
> // This is expensive.
> if (kv.isLatestTimestamp() && kv.isDeleteType()) {
> {code}
> Basically used a wrong API.
> kv.isDeleteType() should be KeyValue.isDelete(type);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
