stoty commented on code in PR #5569:
URL: https://github.com/apache/hbase/pull/5569#discussion_r1419306021
##########
pom.xml:
##########
@@ -981,7 +981,9 @@
--add-opens java.base/java.util=ALL-UNNAMED
--add-opens java.base/java.util.concurrent=ALL-UNNAMED
--add-exports java.base/jdk.internal.misc=ALL-UNNAMED
- --add-exports
java.security.jgss/sun.security.krb5=ALL-UNNAMED</hbase-surefire.jdk11.flags>
+ --add-exports java.security.jgss/sun.security.krb5=ALL-UNNAMED
+ --add-exports java.base/sun.net.dns=ALL-UNNAMED
Review Comment:
The packages are present in JDK 11.
It seems that these modules were added JDK 11, but are only enforced in
JDK17.
I have confirmed that JDK11 accepts these parameters, and does not print
warnings.
AFAIU If we added these for JDK17 only, that would solve the JDK startup
failure problem shown in the stack trace, but JDK11 would still print warnings
when we execute those Hadoop methods.
So I believe that the correct place to add them is JDK11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
