sunhelly commented on PR #5518:
URL: https://github.com/apache/hbase/pull/5518#issuecomment-1855105270
> > > Have you check the ref guide? For me, I think setting the replica mode
to something other than NONE indicates that the user wants to use meta replica?
> >
> >
> > Thanks, @Apache9 . The ref guide doesn't bound the relation ship between
the two configs. I think, when we enabling the meta replica, we will set both
the two configs under normal circumstances. But when encountering problems
caused by meta replica, disable it throught the configs is a quick recover
method. The key problem here is that we should disable meta replica by only one
config("hbase.meta.replicas.use") or both the relevant configs. I prefer the
first way, but I'm neutral on both the ways.
>
> Maybe at client side we just do not care about `hbase.meta.replicas.use`?
The `hbase.meta.replicas.use` config is only for server side. So maybe a more
suitable way here is that, at server side, like when initialize a region server
or master, when `hbase.meta.replicas.use` is set to false, we force set the
replica mode to NONE as it is useless to use other replica modes?
Thanks， @Apache9 . I think the config `hbase.meta.replicas.use` appears
before `hbase.locator.meta.replicas.mode`, which is brought by
[HBASE-25126](https://issues.apache.org/jira/browse/HBASE-25126) to introduce
more meta access mode for clients. And at the server side, in the
initialization of regionserver and master, the `hbase.meta.replicas.use`
actively force the setting to false, see line
https://github.com/apache/hbase/blob/29bfc610d0433f720a34bc47aadca1433bbb1882/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L515
and
https://github.com/apache/hbase/blob/29bfc610d0433f720a34bc47aadca1433bbb1882/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L529.
As a result, I think the replica mode should be force set to NONE at both
server side and client side. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
