bbeaudreault commented on code in PR #5580:
URL: https://github.com/apache/hbase/pull/5580#discussion_r1426674076
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java:
##########
@@ -106,15 +106,13 @@ public final class X509Util {
"hbase.server.netty.tls.supportplaintext";
/**
- * Set the SSL wrapSize for netty. This is only a maximum wrap size. Buffers
smaller
- * than this will not be consolidated, but buffers larger than this will be
split into
- * multiple wrap buffers. The netty default of 16k is not great for hbase
which tends to
- * return larger payloads than that, meaning most responses end up getting
chunked up.
- * This leads to more memory contention in netty's PoolArena.
- * See https://github.com/netty/netty/pull/13551
+ * Set the SSL wrapSize for netty. This is only a maximum wrap size. Buffers
smaller than this
+ * will not be consolidated, but buffers larger than this will be split into
multiple wrap
+ * buffers. The netty default of 16k is not great for hbase which tends to
return larger payloads
+ * than that, meaning most responses end up getting chunked up. This leads
to more memory
+ * contention in netty's PoolArena. See
https://github.com/netty/netty/pull/13551
*/
- public static final String HBASE_SERVER_NETTY_TLS_WRAP_SIZE =
- "hbase.server.netty.tsl.wrapSize";
+ public static final String HBASE_SERVER_NETTY_TLS_WRAP_SIZE =
"hbase.server.netty.tsl.wrapSize";
Review Comment:
thanks for that catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
