NihalJain commented on code in PR #5581:
URL: https://github.com/apache/hbase/pull/5581#discussion_r1427963870
##########
bin/hbase:
##########
@@ -496,7 +496,7 @@ add_jdk11_deps_to_classpath() {
}
add_jdk11_jvm_flags() {
- HBASE_OPTS="$HBASE_OPTS
-Dorg.apache.hbase.thirdparty.io.netty.tryReflectionSetAccessible=true
--add-modules jdk.unsupported --add-opens java.base/java.nio=ALL-UNNAMED
--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens
java.base/java.lang=ALL-UNNAMED --add-opens
java.base/jdk.internal.ref=ALL-UNNAMED --add-opens
java.base/java.lang.reflect=ALL-UNNAMED --add-exports
java.base/jdk.internal.misc=ALL-UNNAMED --add-exports
java.security.jgss/sun.security.krb5=ALL-UNNAMED --add-exports
java.base/sun.net.dns=ALL-UNNAMED --add-exports
java.base/sun.net.util=ALL-UNNAMED"
+ HBASE_OPTS="$HBASE_OPTS
-Dorg.apache.hbase.thirdparty.io.netty.tryReflectionSetAccessible=true
--add-modules jdk.unsupported --add-opens java.base/java.io=ALL-UNNAMED
--add-opens java.base/java.nio=ALL-UNNAMED --add-opens
java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED
--add-opens java.base/jdk.internal.ref=ALL-UNNAMED --add-opens
java.base/java.lang.reflect=ALL-UNNAMED --add-exports
java.base/jdk.internal.misc=ALL-UNNAMED --add-exports
java.security.jgss/sun.security.krb5=ALL-UNNAMED --add-exports
java.base/sun.net.dns=ALL-UNNAMED --add-exports
java.base/sun.net.util=ALL-UNNAMED"
Review Comment:
Do we not need to add this in pom.xml:
https://github.com/apache/hbase/blob/29cf51d8391099f5628a52d2c3306932758d4108/pom.xml#L974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
