NihalJain commented on PR #5588:
URL: https://github.com/apache/hbase/pull/5588#issuecomment-1862605345

   In this PR have remove the redundant imports as the scripts run even w/o 
them. Also removed banned log4j imports as jruby scripts run with 
`org.jruby.Main` fail without it) 
   
   Tested them as follows:
   - Build code with `assembly:single`
   - Untar the tarball
   - Start hbase in local mode
   - Create a table 't1' via shell: `create 't1', 'cf'`
   - Run following to test:
     -  `./hbase org.jruby.Main get-active-master.rb`
     - `./hbase org.jruby.Main replication/copy_tables_desc.rb 
127.0.0.1:2181:/hbase  127.0.0.1:2181:/hbase t1`
     - `./hbase org.jruby.Main draining_servers.rb add hostname:16020`
     - `./hbase org.jruby.Main draining_servers.rb list`
     -  `./hbase org.jruby.Main draining_servers.rb remove hostname:16020`
     - `./hbase org.jruby.Main shutdown_regionserver.rb IP:16020`
   - Also copied new log4j command in shell verified no error.
   - Also ran `hbase-shell` tests locally
   
   Will fix `region_status.rb` as part of HBASE-28273.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to