bbeaudreault commented on PR #5579: URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863113068
> +1 to the change. > > Just realized, we may want to add sample command which sets EC in doc section of `create.rb` and `alter.rb`. We usually add those for any new feature that we add. Or could be done as part of documentation story as well. If you don't mind, I might file a new jira for this. I took a look, and yes we put a bunch of examples in there but there doesn't seem to be any rhyme or reason. I wonder if we should improve the help text to list the possible options explicitly. We already hardcode the supported options in `admin.rb -- update_tdb_from_arg`, so it seems like we could refactor that a bit to print them to the help text. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
