NihalJain commented on PR #5594:
URL: https://github.com/apache/hbase/pull/5594#issuecomment-1865258878
Logs (with extra debug info) to demonstrate why the tests were failing. It
can be seen the count was not 1 as it was expected in test assertion.
Changed logic to do counting relatively instead of absolutely, which was
causing flakiness, due to test case ordering.
```
server_name=HOST_NAME,63596,1703112668148
2023-12-21T04:22:20,258 DEBUG [Listener at localhost/63569-EventThread {}]
zookeeper.ZKWatcher(604): master:63585-0x100004905c30000,
quorum=127.0.0.1:64405, baseZNode=/hbase Received ZooKeeper Event,
type=NodeChildrenChanged, state=SyncConnected, path=/hbase/draining
2023-12-21T04:22:20,258 INFO
[RpcServer.default.FPBQ.Fifo.handler=2,queue=0,port=63585 {}]
master.ServerManager(681): Server HOST_NAME,63596,1703112668148 added to
draining server list.
Took 0.0068 seconds
2023-12-21T04:22:20,259 DEBUG [zk-event-processor-pool-0 {}]
zookeeper.ZKUtil(111): master:63585-0x100004905c30000, quorum=127.0.0.1:64405,
baseZNode=/hbase Set watcher on existing
znode=/hbase/draining/HOST_NAME,63602,1703112668656
2023-12-21T04:22:20,259 DEBUG [zk-event-processor-pool-0 {}]
zookeeper.ZKUtil(111): master:63585-0x100004905c30000, quorum=127.0.0.1:64405,
baseZNode=/hbase Set watcher on existing
znode=/hbase/draining/HOST_NAME,63599,1703112668493
2023-12-21T04:22:20,259 DEBUG [zk-event-processor-pool-0 {}]
zookeeper.ZKUtil(111): master:63585-0x100004905c30000, quorum=127.0.0.1:64405,
baseZNode=/hbase Set watcher on existing
znode=/hbase/draining/HOST_NAME,63596,1703112668148
2023-12-21T04:22:20,259 WARN [zk-event-processor-pool-0 {}]
master.ServerManager(677): Server HOST_NAME,63602,1703112668656 is already in
the draining server list.Ignoring request to add it again.
2023-12-21T04:22:20,259 INFO [zk-event-processor-pool-0 {}]
master.DrainingServerTracker(92): Draining RS node created, adding to list
[HOST_NAME,63602,1703112668656]
2023-12-21T04:22:20,259 WARN [zk-event-processor-pool-0 {}]
master.ServerManager(677): Server HOST_NAME,63599,1703112668493 is already in
the draining server list.Ignoring request to add it again.
2023-12-21T04:22:20,259 INFO [zk-event-processor-pool-0 {}]
master.DrainingServerTracker(92): Draining RS node created, adding to list
[HOST_NAME,63599,1703112668493]
2023-12-21T04:22:20,259 WARN [zk-event-processor-pool-0 {}]
master.ServerManager(677): Server HOST_NAME,63596,1703112668148 is already in
the draining server list.Ignoring request to add it again.
2023-12-21T04:22:20,259 INFO [zk-event-processor-pool-0 {}]
master.DrainingServerTracker(92): Draining RS node created, adding to list
[HOST_NAME,63596,1703112668148]
DECOMMISSIONED REGION SERVERS
HOST_NAME,63599,1703112668493
HOST_NAME,63602,1703112668656
HOST_NAME,63596,1703112668148
3 row(s)
Took 0.0015 seconds
initial_number_of_rows=3
2023-12-21T04:22:20,267 DEBUG [Listener at localhost/63569-EventThread {}]
zookeeper.ZKWatcher(604): master:63585-0x100004905c30000,
quorum=127.0.0.1:64405, baseZNode=/hbase Received ZooKeeper Event,
type=NodeDeleted, state=SyncConnected,
path=/hbase/draining/HOST_NAME,63596,1703112668148
2023-12-21T04:22:20,267 DEBUG [Listener at localhost/63569-EventThread {}]
zookeeper.ZKWatcher(604): master:63585-0x100004905c30000,
quorum=127.0.0.1:64405, baseZNode=/hbase Received ZooKeeper Event,
type=NodeChildrenChanged, state=SyncConnected, path=/hbase/draining
2023-12-21T04:22:20,268 INFO [zk-event-processor-pool-0 {}]
master.DrainingServerTracker(109): Draining RS node deleted, removing from list
[HOST_NAME,63596,1703112668148]
Took 0.0070 seconds
2023-12-21T04:22:20,268 DEBUG [zk-event-processor-pool-0 {}]
zookeeper.ZKUtil(111): master:63585-0x100004905c30000, quorum=127.0.0.1:64405,
baseZNode=/hbase Set watcher on existing
znode=/hbase/draining/HOST_NAME,63602,1703112668656
2023-12-21T04:22:20,269 DEBUG [zk-event-processor-pool-0 {}]
zookeeper.ZKUtil(111): master:63585-0x100004905c30000, quorum=127.0.0.1:64405,
baseZNode=/hbase Set watcher on existing
znode=/hbase/draining/HOST_NAME,63599,1703112668493
2023-12-21T04:22:20,269 WARN [zk-event-processor-pool-0 {}]
master.ServerManager(677): Server HOST_NAME,63602,1703112668656 is already in
the draining server list.Ignoring request to add it again.
2023-12-21T04:22:20,269 INFO [zk-event-processor-pool-0 {}]
master.DrainingServerTracker(92): Draining RS node created, adding to list
[HOST_NAME,63602,1703112668656]
2023-12-21T04:22:20,269 WARN [zk-event-processor-pool-0 {}]
master.ServerManager(677): Server HOST_NAME,63599,1703112668493 is already in
the draining server list.Ignoring request to add it again.
2023-12-21T04:22:20,269 INFO [zk-event-processor-pool-0 {}]
master.DrainingServerTracker(92): Draining RS node created, adding to list
[HOST_NAME,63599,1703112668493]
DECOMMISSIONED REGION SERVERS
HOST_NAME,63599,1703112668493
HOST_NAME,63602,1703112668656
2 row(s)
Took 0.0025 seconds
final_number_of_rows=2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
