kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1879650845
> I think the PR still needs a lot of polishing... > > A lot of changes seems unrelated, and the new flag does not work for mob and stripe compaction? At least we should discuss this in the design doc first. @Apache9, I appreciate your review feedback and questions. I have answered your questions. Let me know if you have further questions or suggestions. I will be happy to improve the PR further. Yes, the dual file compaction is an improvement over the default compaction only currently. It can be extended to the stripe and mob compactions too. Please note that the dual file compaction is an optional improvement and it will be turned off by default. I think it is too early to make further changes in the code base for this improvement at this moment. I am looking forward to enabling this improvement in production at my company. Based on our experience and learning, we can decide to extend it for other compactions on mutable data. I hope this makes sense to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
