NihalJain commented on code in PR #5607:
URL: https://github.com/apache/hbase/pull/5607#discussion_r1444027067
##########
hbase-assembly/src/main/assembly/hadoop-three-compat.xml:
##########
@@ -115,6 +115,13 @@
<exclude>junit:junit</exclude>
<exclude>org.hamcrest:hamcrest-core</exclude>
<exclude>org.mockito:mockito-core</exclude>
+ <!-- Exclude transitive dependencies of tomcat-jasper, not
needed at runtime -->
Review Comment:
I tested out master startup in local mode. Was able to start with just
tomcat-jasper, tomcat-jasper-el and tomcat-el-api and hence removed others.
Also these 3 jars bring in all those classes which are getting removed from
classpath due to removal of javax.el and javax.servlet.jsp.
Can keep these for safer side. Please let me know WDYT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
