[ 
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Baranau updated HBASE-4050:
--------------------------------

    Attachment: HBASE-4050-8_1.patch

Tried to sketch what I suggested so that it is easier to follow. Haven't added 
implementations in hadoop1/2-compat modules of the interfaces I added to 
hadoop-compat, but they should be pretty much clear: they will be just 
wrappers/proxies on top of hadoop.metrics2 classes.

bq. you would be forced to create whole wrapper classes around every class.

Yeah.. That is what I meant by 
bq. The only fear is that by going with lower-level tools shims we might end up 
having more of these shim classes/interfaces 

Not sure how many of them will be needed, i.e. can't say how much bad it is. I 
believe we'll need just several (Elliott's patch uses just 2) and their 
interfaces are very small.


Anyhow, I will be completely OK if you turn down my suggestion. Just wanted to 
share thoughts in which I saw some benefits (though there are cons as well)
                
> Update HBase metrics framework to metrics2 framework
> ----------------------------------------------------
>
>                 Key: HBASE-4050
>                 URL: https://issues.apache.org/jira/browse/HBASE-4050
>             Project: HBase
>          Issue Type: New Feature
>          Components: metrics
>    Affects Versions: 0.90.4
>         Environment: Java 6
>            Reporter: Eric Yang
>            Assignee: Elliott Clark
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 4050-metrics-v2.patch, 4050-metrics-v3.patch, 
> HBASE-4050-0.patch, HBASE-4050-1.patch, HBASE-4050-2.patch, 
> HBASE-4050-3.patch, HBASE-4050-5.patch, HBASE-4050-6.patch, 
> HBASE-4050-7.patch, HBASE-4050-8.patch, HBASE-4050-8_1.patch, HBASE-4050.patch
>
>
> Metrics Framework has been marked deprecated in Hadoop 0.20.203+ and 0.22+, 
> and it might get removed in future Hadoop release.  Hence, HBase needs to 
> revise the dependency of MetricsContext to use Metrics2 framework.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to