Re: [PR] HBASE-27814 Add support for dump and process metrics servlet in REST … [hbase]

Sat, 13 Jan 2024 08:36:38 -0800 


NihalJain commented on PR #5215:
URL: https://github.com/apache/hbase/pull/5215#issuecomment-1890587435

   > Started a local cluster and started HBase REST server.
   > 
   > 1. Verified the landing page has the right page title, all the tabs are 
visible, hostname is displayed instead of portnumber and no error in page 
rendering.
   >    
   >    * Before Patch:
   >      
   >      * <img alt="before_homepage" width="1791" 
src="https://user-images.githubusercontent.com/3429351/235911953-1f879196-ccdd-4ec7-9e23-0ef99adc9c09.png";>
   >    * After  Patch
   >      
   >      * <img alt="after_homepage" width="1786" 
src="https://user-images.githubusercontent.com/3429351/235911996-0e40d3dd-f4a1-4d56-ade8-3784f3559e75.png";>
   > 2. Verified /logLevel page is fixed with appropriate tabs, as expected and 
shown in [HBASE-20693](https://issues.apache.org/jira/browse/HBASE-20693)
   >    
   >    * Before Patch:
   >      
   >      * <img alt="before_log_level_page" width="1505" 
src="https://user-images.githubusercontent.com/3429351/235912456-d4cea975-7973-46ae-a1d9-306f656995e4.png";>
   >    * After  Patch
   >      
   >      * <img alt="after_log_level_page" width="1459" 
src="https://user-images.githubusercontent.com/3429351/235912489-8cf2d1fe-288d-40e2-af08-f154f773c13b.png";>
   > 3. Verified newly added http://localhost:9093/processRest.jsp works as 
expected
   > 
   > * <img alt="after_new_process_metrics_" width="1791" 
src="https://user-images.githubusercontent.com/3429351/235913580-97f12110-5f0b-4529-8ed3-7fb531ce3799.png";>
   > 
   > 4. Verified newly added  http://localhost:9093/dump page works as expected
   > 
   > * <img alt="after_new_dump_p" width="1580" 
src="https://user-images.githubusercontent.com/3429351/235912652-5b113774-8c76-4953-92ae-5017552597f4.png";>
   > * Sample page output
   > 
   > ```
   > REST Server status for SOME_HOSTNAME,9092,1683113342961 as of Wed May 03 
17:05:00 IST 2023
   > 
   > 
   > Version Info:
   > ===========================================================
   > HBase 3.0.0-alpha-4-SNAPSHOT
   > Source code repository git://XXXX/Users/nihaljain/code/os/hbase 
revision=a814a2e70d6f440aabbea85027777240b5140ba8
   > Compiled by nihaljain on Wed May  3 16:44:26 IST 2023
   > From source with checksum 
58bf02a2ad860d0d181b055736d30da333495012871c91398f10540c77b85a9d23c7b2254bf7f79309645ba8c0fda610aae460be7c2cfc05773bbdb55bcae1d5
   > Hadoop 3.2.4
   > Source code repository Unknown 
revision=7e5d9983b388e372fe640f21f048f2f2ae6e9eba
   > Compiled by ubuntu on 2022-07-12T11:58Z
   > 
   > 
   > Stacks:
   > ===========================================================
   > Process Thread Dump: 
   > 28 active threads
   > Thread 44 (Session-Scheduler-3e8f7922-1):
   >   State: TIMED_WAITING
   >   Blocked count: 0
   >   Waited count: 1
   >   Stack:
   >     sun.misc.Unsafe.park(Native Method)
   >     java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
   >     
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
   >     
java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1093)
   >     
java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:809)
   >     
java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074)
   >     
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
   >     
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
   >     java.lang.Thread.run(Thread.java:748)
   > .
   > .
   > Thread 1 (main):
   >   State: WAITING
   >   Blocked count: 1
   >   Waited count: 8
   >   Waiting on java.lang.Object@348684ed
   >   Stack:
   >     java.lang.Object.wait(Native Method)
   >     java.lang.Object.wait(Object.java:502)
   >     
org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool.join(QueuedThreadPool.java:744)
   >     
org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.join(Server.java:566)
   >     org.apache.hadoop.hbase.rest.RESTServer.join(RESTServer.java:432)
   >     org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:493)
   > 
   > 
   > REST Server configuration:
   > ===========================================================
   > <?xml version="1.0" encoding="UTF-8" standalone="no"?><configuration>
   > 
<property><name>io.storefile.bloom.block.size</name><value>131072</value><final>false</final><source>hbase-default.xml</source></property>
   > 
<property><name>yarn.resourcemanager.opportunistic-container-allocation.enabled</name><value>false</value><final>false</final><source>yarn-default.xml</source></property>
   > .
   > .
   > </configuration>
   > 
   > Logs
   > ===========================================================
   > +++++++++++++++++++++++++++++++
   > 
/Users/nihjain/Desktop/test/hbase-3.0.0-alpha-4-SNAPSHOT/bin/../logs/hbase-nihjain-rest-XXXX.log
   > +++++++++++++++++++++++++++++++
   > core file size              (blocks, -c) 0
   > data seg size               (kbytes, -d) unlimited
   > file size                   (blocks, -f) unlimited
   > max locked memory           (kbytes, -l) unlimited
   > max memory size             (kbytes, -m) unlimited
   > open files                          (-n) XXX
   > pipe size                (XXX bytes, -p) 1
   > stack size                  (kbytes, -s) XXXX
   > cpu time                   (seconds, -t) unlimited
   > max user processes                  (-u) XXXX
   > virtual memory              (kbytes, -v) unlimited
   > 2023-05-03T16:59:01,742 INFO  [main] RESTServer: ***** STARTING service 
'RESTServer' *****
   > 2023-05-03T16:59:01,766 INFO  [main] util.VersionInfo: HBase 
3.0.0-alpha-4-SNAPSHOT
   > 2023-05-03T16:59:01,766 INFO  [main] util.VersionInfo: Source code 
repository git://XXXX/Users/nihaljain/code/os/hbase 
revision=a814a2e70d6f440aabbea85027777240b5140ba8
   > ```
   > 
   > 5. Verified all other pages like /logs, /jmx, /conf works as before
   > 
   > Also tried the patch on a real cluster by building against 2.5.x and 
verified above points.
   
   Reverfied all of this. I also wrote a simple postman collection for basic 
CRUD test for REST at 
https://gist.github.com/NihalJain/7db91823bd140e41953a88eb3df56eae 
   
   Can we keep this inside test resources of hbase REST? Might be useful for 
others as well. Please let me know what you think.
   CC: @ndimiduk  
   <img width="427" alt="Screenshot 2024-01-13 at 9 18 48 PM" 
src="https://github.com/apache/hbase/assets/3429351/c7931f04-4641-4030-9879-dd11c36a245a";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to