[
https://issues.apache.org/jira/browse/HBASE-28314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807728#comment-17807728
]
Istvan Toth commented on HBASE-28314:
-------------------------------------
The original patch is https://github.com/apache/hbase/pull/5630
Compared to master, that one generates source jars in the following modules:
hbase-annotations
hbase-compression-*
hbase-it
hbase-server
hbase-testing-util
hbase-zookeeper
These all have java sources.
The centralized patch is https://github.com/apache/hbase/pull/5635
The centralized version also generates sources in the following modules:
hbase-client-project
hbase-shaded-*
hbase-checkstyle
hbase-openssl
hbase-resource-bundle
hbase-client-project SHOULD have sources, it's just missing from the current
base patch.
The rest don't have any java sources, and the source jars don't contain
anything useful, only the pom, and some license files.
I can see three options:
- Use the base patch (fix it by adding teh plugin to the hbase-client-project)
- Use the centralized patch, but define the maven-source-plugin in the modules
without source code with the skip option
- Use the centralized patch, and don't worry about the spurious source jars
generated
What's your take [~zhangduo] ?
> Generate source artifacts from mvn install for every module containing sources
> ------------------------------------------------------------------------------
>
> Key: HBASE-28314
> URL: https://issues.apache.org/jira/browse/HBASE-28314
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.5.7
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> There is no source jar generated for hbase-server.
> Enabling maven-source-plugin seems to work fine, and Eclipse can use the
> generated sources jar for debugging etc.
> It seems that these source JARs are not generated at least since HBase 2.0.0,
> but we did have source JARs sometime in the 1.x time frame.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
