Apache9 commented on code in PR #5637:
URL: https://github.com/apache/hbase/pull/5637#discussion_r1456756258
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java:
##########
@@ -44,8 +46,11 @@ public class HBasePolicyProvider extends PolicyProvider {
new Service("security.client.protocol.acl",
RegistryProtos.ClientMetaService.BlockingInterface.class),
new Service("security.admin.protocol.acl",
MasterService.BlockingInterface.class),
+ new Service("security.admin.protocol.acl",
LockService.BlockingInterface.class),
Review Comment:
I added a UT in this PR to find out the inconsistency between
HBasePolicyProvider, SecurityInfo and the services deployed in our
MasterRpcServices and RSRpcServices, and then found out that LockService is
missing, so it should have been broken for a long time.
I searched the code base, had not found any references to this service,
maybe it is not exposed through our normal client API, but since it is exposed
as an rpc service, we should fix it anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
