Apache9 commented on PR #5641: URL: https://github.com/apache/hbase/pull/5641#issuecomment-1902548832
The key point for whether we need to refresh the store files is that, the store file can be changed outside our control. This could only happen when we are a secondary replica, as all writes will go to the primary replica and the primary replica will do flush and compact, which change the store files. And I got your point, that if the table itself is readonly, we can make sure that there will be no writes to the primary replica, so we do not need to refresh secondary replicas too. So I prefer we change the condition to check primary region first, and then check whether the table is in read only mode. In both cases, we skip the refreshing. And better also add more comments to describe the logic here. WDYT? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
