[
https://issues.apache.org/jira/browse/HBASE-28302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809979#comment-17809979
]
ASF GitHub Bot commented on HBASE-28302:
----------------------------------------
bbeaudreault commented on PR #5622:
URL: https://github.com/apache/hbase/pull/5622#issuecomment-1906229934
Thanks for the review! Yea it's pretty annoying to handle thrift, since I
needed to go figure out how to generate them. But that seems to be how it works
today. We could probably try to give it the protobuf-like treatment in a
separate jira if anyone wants to improve the thrift build.
> Add tracking of fs read times in ScanMetrics and slow logs
> ----------------------------------------------------------
>
> Key: HBASE-28302
> URL: https://issues.apache.org/jira/browse/HBASE-28302
> Project: HBase
> Issue Type: Improvement
> Reporter: Bryan Beaudreault
> Priority: Major
>
> We've had this in our production for a while, and it's useful info to have.
> We already track FS read times in
> [HFileBlock|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java#L1828-L1831C10].
> We can project that into the ScanMetrics instance and slow log pretty
> easily. It is also helpful to add a slow.fs.read.threshold, over which we log
> a warn
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
