[
https://issues.apache.org/jira/browse/HBASE-28313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810445#comment-17810445
]
ASF GitHub Bot commented on HBASE-28313:
----------------------------------------
Apache-HBase commented on PR #5641:
URL: https://github.com/apache/hbase/pull/5641#issuecomment-1908315197
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 12s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 7s | master passed |
| +1 :green_heart: | compile | 3m 11s | master passed |
| +1 :green_heart: | checkstyle | 0m 44s | master passed |
| +1 :green_heart: | spotless | 0m 52s | branch has no errors when
running spotless:check. |
| +1 :green_heart: | spotbugs | 2m 29s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 22s | the patch passed |
| +1 :green_heart: | compile | 3m 7s | the patch passed |
| +1 :green_heart: | javac | 3m 7s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 44s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | hadoopcheck | 5m 37s | Patch does not cause any
errors with Hadoop 3.3.6. |
| +1 :green_heart: | spotless | 0m 42s | patch has no errors when
running spotless:check. |
| +1 :green_heart: | spotbugs | 1m 48s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 9s | The patch does not generate
ASF License warnings. |
| | | 32m 8s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.44 ServerAPI=1.44 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/5641 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti
spotless checkstyle compile |
| uname | Linux 5ddf8893bce4 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2
11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 354a3a2774 |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| Max. process+thread count | 87 (vs. ulimit of 30000) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/console
|
| versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> StorefileRefresherChore should not refresh readonly table
> ---------------------------------------------------------
>
> Key: HBASE-28313
> URL: https://issues.apache.org/jira/browse/HBASE-28313
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 2.4.17
> Reporter: Hao Sun
> Priority: Major
> Fix For: 2.4.17
>
>
> According to semantics, when StoreFile Refresher is turned on, only the area
> with replicas should be refreshed. *Tables with read-only attributes will not
> be refreshed.*
> There are the following scenarios: Assume that some tables in the database
> have replica enabled, while others do not. If a table that does not have
> replica enabled needs to perform migration tasks - first enable readonly and
> then export the snapshot, StorefileRefresherChore will always refresh the
> table that does not have replica enabled but performs migration tasks. This
> is obviously illogical.
> Therefore, StorefileRefresherChore needs to determine whether the region has
> a read-only copy, and refresh it if it has a read-only copy. And tables with
> read-only properties are not refreshed.
> patch:[HBASE-28313|https://github.com/apache/hbase/pull/5641]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
