rmdmattingly commented on code in PR #5654:
URL: https://github.com/apache/hbase/pull/5654#discussion_r1467622755


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -2047,6 +2049,16 @@ public Configuration getReadOnlyConfiguration() {
     return new ReadOnlyConfiguration(this.conf);
   }
 
+  @Override
+  public int getMinBlockSizeBytes() {
+    if (minBlockSizeBytes > 0) {
+      return minBlockSizeBytes;
+    }
+    minBlockSizeBytes = 
Arrays.stream(this.htableDescriptor.getColumnFamilies())
+      
.mapToInt(ColumnFamilyDescriptor::getBlocksize).min().orElse(HConstants.DEFAULT_BLOCKSIZE);
+    return minBlockSizeBytes;
+  }

Review Comment:
   Good thinking



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to